[Feedback] Tedious v2.1.0 release

[arthurschreiber]

[email protected] was released to the tedious@next pre-release channel.

If you want to test this new version, you can install it via npm install tedious@next or npm install [email protected].

We plan to keep this new release in the next channel for at least a week, to gather feedback and gain confidence, before releasing this version to the latest channel. Please let us know if you run into any issues.

---

Changes since [email protected]

Bug Fixes

• Do not send username and password via LOGIN7 when a domain is set. (fix: Do not send username and password via LOGIN7 when a domain is set. #630) (c9b3fdb2)

Features

• Allow requests to be paused and resumed. (Implements Request.pause() / resume() #518) (9ef0d58d)

---

Known Issues

• Deployments to Azure fail because of the sspi-client dependency.

[arthurschreiber]

As we already know that deployments to Azure for applications using [email protected] will fail, we will push a new version that fixes this shortly to the next release channel.

[jdownhower]

Is there an issue with using Tedious on a table with more than 130 columns? When Tedious 2.1.1 is being used via Sequelize, I am getting "RangeError: Maximum call stack size exceeded".

[Suraiya-Hameed]

@jdownhower Do you get RangeError with [email protected] too? or is it just with [email protected]? Can you share some detail on what operation is being performed? which API or function triggers this?

[jdownhower]

@v-suhame I created an isolated test case and put it in this repository, so hopefully it is reproducible. It also includes the detailed error (output.txt). Hope this is helpful.

[Suraiya-Hameed]

@jdownhower Thanks for the repo!
To sum up the issue, on reading a row with 130+ column, RangeError: Maximum call stack size exceeded is thrown.

This issue is due to nested callbacks in the driver, it is a known one (#512), @arthurschreiber was working on a fix, maybe he can give more details.

Workaround for now would be to decrease the packet-size of message, default packet size is 4 * 1024, you can set it with config.options.packetSize.

[jdownhower]

@v-suhame Thank you! I was able to use the Sequelize dialectOptions to pass the new packetSize value to Tedious as a workaround.

[arthurschreiber]

@jdownhower As @v-suhame correctly said, the issue is with a recursive code path in the current TDS packet parser. We hope to tackle this issue in the future! 😄

[arthurschreiber]

I just tagged [email protected] as latest to mark it as stable! 🎉