Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cancel' function on Request class #534

Closed
tvrprasad opened this issue Mar 9, 2017 · 4 comments
Closed

Add 'cancel' function on Request class #534

tvrprasad opened this issue Mar 9, 2017 · 4 comments

Comments

@tvrprasad
Copy link
Contributor

Currently 'cancel' is on Connection. This works fine since we only have a single Request per connection right now. It belongs on Request class logically though as it's the Request that's being cancelled.

We should mark the cancel function on Connection class deprecated so we can remove it in a later release.

@chdh
Copy link
Collaborator

chdh commented Mar 10, 2017

Some additional info to justify this:

  • In the upper level driver node-mssql, the cancel() method is a member of the Request class.
  • In the .NET API, the Cancel() method ist a member of the SqlCommand class.

When cancel() is called on a Request object, the implementation must check whether the Request object really represents the currently active request.

@arthurschreiber
Copy link
Collaborator

Yeah, this definately feels like it should be on the Request and not the Connection, long term.

We can deprecate this somewhere in the 2.x releases and drop it in 3.0.

@arthurschreiber
Copy link
Collaborator

This will be added via #846. 😬

@arthurschreiber
Copy link
Collaborator

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants