-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'cancel' function on Request class #534
Comments
Some additional info to justify this:
When cancel() is called on a Request object, the implementation must check whether the Request object really represents the currently active request. |
Yeah, this definately feels like it should be on the Request and not the Connection, long term. We can deprecate this somewhere in the 2.x releases and drop it in 3.0. |
This will be added via #846. 😬 |
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Currently 'cancel' is on Connection. This works fine since we only have a single Request per connection right now. It belongs on Request class logically though as it's the Request that's being cancelled.
We should mark the cancel function on Connection class deprecated so we can remove it in a later release.
The text was updated successfully, but these errors were encountered: