Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --confirm-prompt option to support prompting if --confirm missing #191

Open
gpoole opened this issue Aug 18, 2020 · 0 comments
Open

Comments

@gpoole
Copy link

gpoole commented Aug 18, 2020

Thanks for the handy plugin.

I usually put my deploy command in my package.json's scripts section, e.g.:

"deploy": "serverless deploy" 

Doing it this way it's a little bit more awkward to pass the --confirm command (npm run deploy -- --confirm) so it'd be nice if I was able to set it up to prompt for a confirmation if a flag isn't provided, e.g. something like:

$ npm run deploy
Are you sure you want to run 'deploy'? y/N

I think the prompt would be off by default and enabled with a flag e.g.:

serverless deploy --confirm-prompt

Would you be interested in a PR for that feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant