Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comic book archives have overcomplicated directory structures #18

Open
techwizrd opened this issue May 12, 2013 · 1 comment
Open

Comic book archives have overcomplicated directory structures #18

techwizrd opened this issue May 12, 2013 · 1 comment

Comments

@techwizrd
Copy link
Owner

Images in the comic book archives are stored in their full directory structure like /home/kunal/Projects/MangaFox-Download-Script/The World God Only Knows/v01c001/ instead of v01c001/. This is not a serious issue but it can expose a user's path information or directory structure in the archive unintentionally and it is just plain weird.
@siikamiika
Copy link

Fixed this in my pull request by calling os.path.basename() on the filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@techwizrd @siikamiika