Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing defaults for some additional props via createTheme / context #67

Closed
techniq opened this issue Jul 26, 2023 · 1 comment
Milestone

Comments

@techniq
Copy link
Owner

techniq commented Jul 26, 2023

While it was decided to only support class/classes props as part of the initial createTheme PR, there are some additional props that could be useful to change the default globally.

  • variant for many components (Button / ButtonGroup, ToggleGroup, ...)
  • TextField and Field labelPlacement
  • maybe others

Will need to identify which props makes sense that provides a good balance between flexibility and ease to maintain.

@techniq techniq added this to the v1 milestone Jul 26, 2023
@techniq techniq changed the title Support passing some props via createTheme / context Support changing defaults for some additional props via createTheme / context Jul 26, 2023
@techniq
Copy link
Owner Author

techniq commented Jul 2, 2024

Support for some default props including labelPlacement, variant, size, etc are available per component (or base component such as Field or Button). See ComponentDefaultProps (which is used by settings() with type safety.

@techniq techniq closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant