Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vitest to 1.x #216

Closed
techniq opened this issue Jan 14, 2024 · 2 comments
Closed

Update vitest to 1.x #216

techniq opened this issue Jan 14, 2024 · 2 comments

Comments

@techniq
Copy link
Owner

techniq commented Jan 14, 2024

We are currently on vitest 0.33 as we ran into Failed to resolve entry for package "@sveltejs/package" when updating to 0.34 initially. This sounds like it can be solved by adding @sveltejs/vite-plugin-svelte as a direct dependency.

I recently tried to update to the latest 1.2.0 as part of updating to Vite 5 / SvelteKit 2, and ran into fsevent errors. See CI logs on the automated PR to update to 0.34

@techniq
Copy link
Owner Author

techniq commented Jan 14, 2024

@dimfeld FYI: Added a new issue to track. I'll take another stab once I ship design tokens / Intl updates, but if you have any ideas, I'm all ears :)

@dimfeld
Copy link
Contributor

dimfeld commented Jan 15, 2024

A few observations:

  • Same results with node 20 or 21
  • This isn't related to anything that the test itself is doing. If I run just a single test, the test runs and passes but it hits the esbuild error afterward anyway.
    CleanShot 2024-01-15 at 13 11 49
  • Note that the above works best with one of the shorter tests, since whatever is causing the error seems to be runnign concurrently
  • Removing the code coverage functionality makes no difference
  • Removing sveld from the vite config makes no difference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants