-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5 support / migration #159
Comments
any headway on |
@oneezy The docs are using Svelte 5, but I haven't started migrating to runes/snippets just yet. Just got back from a family vacation and transitioning jobs this/next week, but plan to start the migration in a couple of weeks. I've got my eye on the Migration Magician SvelteHack category and we'll see if I can make the Jan 9th deadline. I'm migrating Svelte UX as well... One thing I need to figure out is @mhkeller's Svelte 5 roadmap for LayerCake. I've been contemplating removing LayerCake as a dependency (at least initially) which would simplify some context and possibly open up additional improvements. Stay tuned, but should see some progress soon. I need to drop a 1.x release for both projects first as this will continue to be Svelte 3-5 compatible, and 2.x+ will be Svelte 5 only (since it will leverage runes, snippets, etc). |
Waiting with anxiety about the svelte 5 migration. |
Hi! 👋 My project uses Svelte 5 in strict runes mode and trying to use
FWIW, I am including this patch that let's me get past the error; and I think might benefit others if you could apply it in an interim release before reaching native Svelte 5 support which I can see is not an insignificant amount of work. Please disregard if this is not worth your time. I am attaching the patch file in case it makes it easier to make that release. PS: I have submitted a similar patch to |
Hey @vijay8i. That's interesting. I see the patch is adding... <svelte:options runes={false} /> to all the components. As long as setting this option doesn't have any Svelte 3/4 compat issues (complains the option doesn't exist, etc), I'm fine with adding it as a temporary solution to improve Svelte 5 compat. If you could validate the change works with Svelte 4 and submit a PR, I'll happily merge it. I haven't been as active on LayerChart development in December due to changing jobs and holidays with family (and a few other items), but plan to start the Svelte 5 migration (as I'm currently working on overhauling how Canvas integration works which will make it much more robust and simplier. The initial work has started in [PR ](#295), but the bigger change I hope to start this week. It's the biggest blocker for Svelte 5 migration work. |
Hi @techniq,
I don't think this patch will work with Svelte 4 or below. This option was introduced in Svelte 5, so pretty iffy to even try on anything lower. The intent of my comment was to hope that you could add this to
I understand. Fwiw, you are way ahead than most of us in our aspirations to build and maintain an open source library that offers utility and is used widely. More power to you. |
Creating an overarching issue to track migrating to Svelte 5.
The plan is for LayerChart 1.x to support Svelte 3, 4, and 5 by not leveraging Svelte 5 specific features like runes and snippets, and 2.x+ will leverage these Svelte 5 specific features.
Outstanding Svelte 5 issues:
Svelte 5: SVG elements within fallback not displayedIssues that should be investigated:
The text was updated successfully, but these errors were encountered: