Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qa on merge to master OR using merge_groups with slack notification #1663

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

robert-bo-davis
Copy link
Collaborator

@robert-bo-davis robert-bo-davis commented Sep 19, 2023

Primary reviewer:

Description

This PR is an example of two potential patterns for streamlining the trunk QA process if we move away from manual QA tags.

These actions have, obviously, not been tested yet, but should be fairly close to working.

Common Functionality:

  1. Create a qa tag based on a version name found in the PR title (ex: a pr with the title v1.2.3 - pre release will produce a qa/v1.2.3 tag.

  2. Create a qa tag based on a ticket number found in the PR title. (ex: a pr with the tittle CHI-1234 - some long description will automatically create the tag qa/CHI-1234 when it is merged.

  3. There is a scheduled job to cleanup qa tags after 2 weeks.

Differences:

global-qa-merge-group.yml

This action is based on the POC work from https://github.com/techmatters/test-merge-group-action. It uses the new github merge_group trigger to run the tests after the "merge" button is pushed on a PR, but before the merge actually happens. If tests fail, the merge will be rejected and won't make it into the target branch. There are quite a few caveats discussed in the POC repo.

global-qa-push.yml

This action is triggered after any code is merged into master. It can't block failing code from making it into master, so it notifies loudly in #aselo-engineering on any failure.

Verification steps

@robert-bo-davis robert-bo-davis changed the title feat: qa on merge to master with slack notification feat: qa on merge to master OR using merge_groups with slack notification Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant