Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosponsorship table's is_sponsor column is empty. #38

Open
aprilrd opened this issue Mar 25, 2015 · 4 comments
Open

cosponsorship table's is_sponsor column is empty. #38

aprilrd opened this issue Mar 25, 2015 · 4 comments

Comments

@aprilrd
Copy link
Contributor

aprilrd commented Mar 25, 2015

If it's by design we should drop the column. If not, we should fix it. (Should be easy.. we can just use the associated bill's information.)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9983576-cosponsorship-table-s-is_sponsor-column-is-empty?utm_campaign=plugin&utm_content=tracker%2F248100&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F248100&utm_medium=issues&utm_source=github).
@e9t
Copy link
Member

e9t commented Mar 25, 2015

The is_sponsor column was originally designed to indicate the representative sponsor (대표발의자) of a bill.
As you said, we can use the corresponding bill's information, specifically by parsing the bill.sponsor column.
All these small issues are bottlenecks for larger feature developments, and should be resolved.

@briatte
Copy link

briatte commented Aug 24, 2015

Hi,

This is a related question from someone who just discovered your wonderful website.

I do not understand why the "Representative sponsor" is sometimes listed as text, and sometimes through a photograph.

Here, it is listed as text: http://en.pokr.kr/bill/110755
And here as a photograph: http://en.pokr.kr/bill/110754

Could you please explain the difference between the two? Sorry if it's really obvious, I unfortunately do not speak Korean.

@e9t
Copy link
Member

e9t commented Aug 30, 2015

Hi @briatte. The "sponsor" field is not the name of the sponsor, but a longer string indicating the number of cosponsors. (i.e., "김집의원 외 51인" == "Cosponsored by [someone's name] and 51 others")
So we iterate over cosponsors and see if any are includes in the "sponsor" field.
If there aren't any matches, we just return the "sponsor" string.
You probably know what I mean since you've seen our API :)

https://github.com/teampopong/pokr.kr/blob/master/pokr/models/bill.py#L99
https://github.com/teampopong/pokr.kr/blob/master/pokr/templates/bill.html#L81

@briatte
Copy link

briatte commented Aug 30, 2015

Alright, thanks for the clarification!

My understanding is that some bills have one or two "primary" sponsor(s), while others do not. That's an interesting but complex scenario: in most countries, bills either have a primary sponsor, or do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants