Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop aliases #159

Closed
5 tasks done
teamon opened this issue Jan 26, 2018 · 0 comments
Closed
5 tasks done

Drop aliases #159

teamon opened this issue Jan 26, 2018 · 0 comments
Labels
breaking
Milestone
1.0

Comments

@teamon
Copy link
Member

teamon commented Jan 26, 2018 •
edited
Loading

It is not widely used nor documented feature, aliases were never kept up to date and with current implementation they add a compile-time link from tesla builder to all adapters and middlewares. And there is no way to make them work for any custom middleware.

  • Remove aliases from code
  • Update tests
  • Update README
  • Add information to migration guide
  • Add compile-time error when using symbols as adapter/middleware
@teamon teamon added this to the 1.0 milestone Jan 26, 2018
@teamon teamon self-assigned this Jan 26, 2018
@teamon teamon removed their assignment Jan 26, 2018
teamon added a commit that referenced this issue Jan 26, 2018
@teamon
Drop aliases #159
5ed79f0
teamon added a commit that referenced this issue Jan 26, 2018
@teamon
Remove aliases from README [close #159]
4e018ff
@teamon teamon closed this as completed Jan 26, 2018
@teamon teamon reopened this Jan 28, 2018
teamon added a commit that referenced this issue Jan 31, 2018
@teamon
Add dropped aliases compile errors #159
fb9bb61
@teamon teamon closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@teamon