Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC General IdP Config Option #782

Open
2 tasks done
lukaskaeppeli opened this issue May 12, 2023 · 4 comments
Open
2 tasks done

OIDC General IdP Config Option #782

lukaskaeppeli opened this issue May 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@lukaskaeppeli
Copy link

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Description

The current implementation supports thirdparty logins from apple, github and google. It would be nice, if you could add a General Provider configuration option for other IdPs. This could even replace the existing providers and reduce complexity.

Describe your ideal solution

No response

Workarounds or alternatives

No response

Hanko Version

v0.6.0

Additional Context

No response

@lukaskaeppeli lukaskaeppeli added the enhancement New feature or request label May 12, 2023
@like-a-bause
Copy link
Contributor

Thanks for the suggestion.

This could even replace the existing providers and reduce complexity.

This will most likely not be possible as Apple does things quite different than other providers and we had to jump some hoops to get this working.

We would have to think about how to integrate this proper into the hanko-elements as well: The display text/ icon of the Button would have to be configurable.

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 27, 2023
@FlxMgdnz FlxMgdnz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
@lfleischmann lfleischmann reopened this Aug 10, 2023
@paustint
Copy link

+1 for this. I just need support for Salesforce, but may as well support generic oicd providers to avoid hundreds of one-off requests - examples of request bombardment here or here.

@FlxMgdnz
Copy link
Member

I agree. Will be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants