-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store dependencies graph in component model #9214
Open
zkochan
wants to merge
121
commits into
teambit:master
Choose a base branch
from
zkochan:store-deps-graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 107 commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
3f7d624
feat: add dependenciesGraph to the model
zkochan 6c129b3
feat: add deps graph to the model
zkochan 77779c5
fix: save dependenciesGraphRef
zkochan 9952238
feat: deps graph in comp model
zkochan cfc5c19
feat: read lockfile from model on sign
zkochan 7a01886
fix: read dependencies graph from root components
zkochan 30d52e5
test: deps graph
zkochan f450ea1
test: deps graph
zkochan d701084
fix: installing from generated lockfile
zkochan 4074f5a
save dev deps in dependency graph
zkochan b172534
fix: generate the correct lockfile after capsules dedupe
zkochan c968a38
test: snapping multiple components
zkochan 4a34cbe
test: signing a component with dependencies graph
zkochan 3bac3b7
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan c317508
test: lockfile used by sign is written by bit
zkochan d6b34f9
feat: generate lockfile on import
zkochan 0a33536
test: generating a lockfile on import
zkochan 76af54f
test: run local registry
zkochan 17be0dd
test: deps are not updated
zkochan f9c4463
test: merging dependency graphs
zkochan 0d38327
fix: mergin dep graphs
zkochan eecee4d
feat: properly resolve dependencies with peer dependencies
zkochan 88fdc7b
test: publishing to registry
zkochan c13c229
test: imported component is not installed as a package dep
zkochan b983c67
test: fix
zkochan 49acf81
test: importing component
zkochan 87cbb8c
fix: don't fail on empty graph
zkochan a522d40
feat: updating package integrities on tag from scope
zkochan f6338da
fix: optimize the deps graph format saved in the model
zkochan aa38916
fix: replacing pending versions
zkochan 24a0193
replace integrities in the model
zkochan d6903c3
test: fix
zkochan aebbce3
feat: add lockfile converter
zkochan 0a505a5
test: converting the lockfile
zkochan 488ff5d
test: fix
zkochan 81ac9c8
test: fix
zkochan 18cc929
test: fix
zkochan ca8e425
feat: add component ID to dep graph
zkochan 48388de
refactor: types
zkochan fa239cd
fix: converting lockfile to graph
zkochan acbde62
fix: replace file deps in direct deps
zkochan 29fb0ad
refactor: change direct deps data structure
zkochan f7bfd96
test: fix
zkochan d40865a
feat: add deps-graph feature flag
zkochan b8e8995
fix: update pnpm
zkochan 20acc56
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 0afa437
fix: compile
zkochan d1fe382
fix: types
zkochan 0db3c10
fix: types
zkochan 099ed91
style: fix
zkochan 0066a70
test: fix
zkochan bf0b921
test: fix
zkochan 86ff144
fix: move deps to package.json
zkochan 7a1d727
remove commented code
zkochan fc0209e
test: fix
zkochan 98bf497
test: fix
zkochan 763db45
test: fix
zkochan 2e5ec64
always write the deps graph data to the model
zkochan a270851
Merge branch 'master' into store-deps-graph
zkochan 95bdef9
refactor: apply suggestions from the code review
zkochan 998335a
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 9046990
fix: compile
zkochan f88b8ae
refactor: apply suggestions from the code review
zkochan b75f99c
refactor: apply suggestions from the code review
zkochan b45dd47
refactor: apply suggestions from the code review
zkochan 0c2fe71
refactor: apply suggestions from the code review
zkochan 631cae0
refactor: apply suggestions from the code review
zkochan fed2b00
refactor: graph
zkochan 73cb5c3
refactor: implement suggestions
zkochan 0187a76
refactor: implement suggestions
zkochan ae3f4c2
refactor: dependencies graph
zkochan f6c45bc
refactor: dependencies graph
zkochan 1934ef3
test: fix
zkochan 2300757
style: fix
zkochan 40396b9
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan cb5b390
test: fix
zkochan aab84fd
test: fix
zkochan d57aa09
style: fix
zkochan 671069f
fix: build
zkochan fa21dc6
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 6e83e65
refactor: implement suggestions
zkochan 7b83856
fix: types
zkochan b775dd1
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 92f75b4
refactor: implement suggestions
zkochan 7a8d730
refactor: dependencies graph
zkochan 260d62d
refactor: don't store empty edges
zkochan 0c03c06
refactor: add lifecycle to direct deps in graph
zkochan 1322d1b
refactor: convert lockfile
zkochan af64291
refactor: convert lockfile
zkochan f3a2690
refactor: remove specifiers from deps graph
zkochan 32af787
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 4f940aa
fix: compile
zkochan d6dcd36
refactor: implement suggestions
zkochan 2ab3888
test: fix
zkochan 19b2963
style: fix
zkochan ff3df60
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan a8ed78d
feat: write dependency graph on sign
zkochan 45fc29b
refactor: lockfile to graph
zkochan 8c7a10b
refactor: lockfile to graph
zkochan 96b4c7c
style: fix
zkochan 4bc17cc
refactor: dependencies graph
zkochan 0cd2d1e
style: fix
zkochan 9d14a7e
test: fix
zkochan 58cf941
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 2d2f411
refactor: lockfile converter
zkochan 42b03dc
refactor: lockfile converter
zkochan 3cb2b2e
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 954ed1d
test: fix
zkochan 6c13ae9
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan eb81dcc
refactor: implement suggestions
zkochan 625faf2
refactor: implement suggestions
zkochan e0149ec
refactor: implement suggestions
zkochan 96b007b
fix: linting error
zkochan a0c13fc
refactor: rename lockfile-converter
zkochan 73302e1
refactor: implement suggestions
zkochan 8e032d9
test: rename cases
zkochan efa6dc7
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan 21caa93
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan d78d9b5
Merge branch 'master' into store-deps-graph
zkochan f7f6628
fix: never dry run when deps graph is used
zkochan 485999d
Merge remote-tracking branch 'origin/master' into store-deps-graph
zkochan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: if I imported a few components (a,b), then I imported a few others (c,d), I will get here with the new ones (c,d) which means I'll build a graph based on c,d ids. which won't include a,b deps. isn't it will result in a wrong merged lock file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will override the lockfile with dependencies of c and d. Dependencies of a and b will be resolved from scratch.