From 08c7c7a86710cb95f836662377a3de1ee1128b7a Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 21:53:10 +0100 Subject: [PATCH 01/17] Create pr-build.yml --- .github/workflows/pr-build.yml | 55 ++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .github/workflows/pr-build.yml diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml new file mode 100644 index 00000000..e47cd82f --- /dev/null +++ b/.github/workflows/pr-build.yml @@ -0,0 +1,55 @@ +name: SonarCloud +on: + push: + branches: + - main + pull_request: + types: [opened, synchronize, reopened] +jobs: + build: + name: Build and analyze + runs-on: windows-latest + steps: + - name: Set up JDK 17 + uses: actions/setup-java@v3 + with: + java-version: 17 + distribution: 'zulu' # Alternative distribution options are available. + - uses: actions/checkout@v3 + with: + fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis + - name: Cache SonarCloud packages + uses: actions/cache@v3 + with: + path: ~\sonar\cache + key: ${{ runner.os }}-sonar + restore-keys: ${{ runner.os }}-sonar + - name: Cache SonarCloud scanner + id: cache-sonar-scanner + uses: actions/cache@v3 + with: + path: .\.sonar\scanner + key: ${{ runner.os }}-sonar-scanner + restore-keys: ${{ runner.os }}-sonar-scanner + - name: Install SonarCloud scanner + if: steps.cache-sonar-scanner.outputs.cache-hit != 'true' + shell: powershell + run: | + New-Item -Path .\.sonar\scanner -ItemType Directory + dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner + - name: Setup .NET 6.x + uses: actions/setup-dotnet@v3 + with: + # Semantic version range syntax or exact version of a dotnet version + dotnet-version: '2.1' + - name: Build and analyze + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + shell: powershell + run: | + .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" + dotnet restore + dotnet build + dotnet test + .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From 10de84f4833bf5ac59a1834f3e63d6898602e646 Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 21:59:53 +0100 Subject: [PATCH 02/17] Change to build to ubuntu --- .github/workflows/pr-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index e47cd82f..15b18094 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -8,7 +8,7 @@ on: jobs: build: name: Build and analyze - runs-on: windows-latest + runs-on: ubuntu-latest steps: - name: Set up JDK 17 uses: actions/setup-java@v3 From 2edc5e3966627ac9435be8bbaa8237300109b19b Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:02:03 +0100 Subject: [PATCH 03/17] Build dotnet command earlier. --- .github/workflows/pr-build.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 15b18094..006edc23 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -31,17 +31,17 @@ jobs: path: .\.sonar\scanner key: ${{ runner.os }}-sonar-scanner restore-keys: ${{ runner.os }}-sonar-scanner + - name: Setup dotnet + uses: actions/setup-dotnet@v3 + with: + # Semantic version range syntax or exact version of a dotnet version + dotnet-version: '2.1' - name: Install SonarCloud scanner if: steps.cache-sonar-scanner.outputs.cache-hit != 'true' shell: powershell run: | New-Item -Path .\.sonar\scanner -ItemType Directory dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner - - name: Setup .NET 6.x - uses: actions/setup-dotnet@v3 - with: - # Semantic version range syntax or exact version of a dotnet version - dotnet-version: '2.1' - name: Build and analyze env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any From ff0759bdfdd4d375826f49d101fd178efed38308 Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:03:45 +0100 Subject: [PATCH 04/17] Go back to windows --- .github/workflows/pr-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 006edc23..09a164e3 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -8,7 +8,7 @@ on: jobs: build: name: Build and analyze - runs-on: ubuntu-latest + runs-on: windows-latest steps: - name: Set up JDK 17 uses: actions/setup-java@v3 From 564058fd0812df8de814d58e2ddd7a1bb89873c2 Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:07:20 +0100 Subject: [PATCH 05/17] Don't run the tests We don't have to run the tests, as the tests are not ready yet (there are no tests) --- .github/workflows/pr-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 09a164e3..281c7557 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -51,5 +51,5 @@ jobs: .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" dotnet restore dotnet build - dotnet test + # dotnet test .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From 6d098635848053e46137d05fc40c38a1cf9b3ff9 Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:14:43 +0100 Subject: [PATCH 06/17] Bump up version of dotnet --- .github/workflows/pr-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 281c7557..a071451b 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -35,7 +35,7 @@ jobs: uses: actions/setup-dotnet@v3 with: # Semantic version range syntax or exact version of a dotnet version - dotnet-version: '2.1' + dotnet-version: '8' - name: Install SonarCloud scanner if: steps.cache-sonar-scanner.outputs.cache-hit != 'true' shell: powershell From cb3e87452e3937e4b022639278e2bec603a32d4a Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:26:10 +0100 Subject: [PATCH 07/17] Reset pipeline MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🙏 🙏 🙏 --- .github/workflows/pr-build.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index a071451b..630a522b 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -31,11 +31,6 @@ jobs: path: .\.sonar\scanner key: ${{ runner.os }}-sonar-scanner restore-keys: ${{ runner.os }}-sonar-scanner - - name: Setup dotnet - uses: actions/setup-dotnet@v3 - with: - # Semantic version range syntax or exact version of a dotnet version - dotnet-version: '8' - name: Install SonarCloud scanner if: steps.cache-sonar-scanner.outputs.cache-hit != 'true' shell: powershell @@ -49,7 +44,5 @@ jobs: shell: powershell run: | .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" - dotnet restore dotnet build - # dotnet test .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From 13506c30a5a4c9e14cdaf0cb5d25d303611e374a Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 12 Feb 2024 22:32:58 +0100 Subject: [PATCH 08/17] Create Main.cs --- Aplib.Core/Main.cs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 Aplib.Core/Main.cs diff --git a/Aplib.Core/Main.cs b/Aplib.Core/Main.cs new file mode 100644 index 00000000..9a8b8fe3 --- /dev/null +++ b/Aplib.Core/Main.cs @@ -0,0 +1,21 @@ +using System; + +namespace Aplib.Core +{ + public class SonarTest + { + public void Main() + { + Console.WriteLine("Hello World!"); + int i = 0; + + while (i < 10) + { + Console.WriteLine(i); + i++; + } + + Console.WriteLine("i is 1"); + } + } +} From 69d9c6cea6984fc7b6992e600782da47fb32ed89 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 15:11:03 +0100 Subject: [PATCH 09/17] feat: add testing framework --- .github/workflows/pr-build.yml | 2 ++ Aplib.Net.sln | 8 +++++++- Aplib.Tests/Aplib.Tests.csproj | 29 +++++++++++++++++++++++++++++ Aplib.Tests/GlobalUsings.cs | 1 + Aplib.Tests/SonarTest.cs | 13 +++++++++++++ 5 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 Aplib.Tests/Aplib.Tests.csproj create mode 100644 Aplib.Tests/GlobalUsings.cs create mode 100644 Aplib.Tests/SonarTest.cs diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 630a522b..a05eb89c 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -44,5 +44,7 @@ jobs: shell: powershell run: | .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" + dotnet restore dotnet build + dotnet test .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" diff --git a/Aplib.Net.sln b/Aplib.Net.sln index b06a17f4..24528aa3 100644 --- a/Aplib.Net.sln +++ b/Aplib.Net.sln @@ -3,7 +3,9 @@ Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio Version 17 VisualStudioVersion = 17.8.34525.116 MinimumVisualStudioVersion = 10.0.40219.1 -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aplib.Core", "Aplib.Core\Aplib.Core.csproj", "{0ED50CC0-F90F-44D4-830E-2F3BACE040EC}" +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aplib.Core", "Aplib.Core\Aplib.Core.csproj", "{0ED50CC0-F90F-44D4-830E-2F3BACE040EC}" +EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Aplib.Tests", "Aplib.Tests\Aplib.Tests.csproj", "{67D4F6C5-758D-489F-A100-8B259B2158D2}" EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution @@ -15,6 +17,10 @@ Global {0ED50CC0-F90F-44D4-830E-2F3BACE040EC}.Debug|Any CPU.Build.0 = Debug|Any CPU {0ED50CC0-F90F-44D4-830E-2F3BACE040EC}.Release|Any CPU.ActiveCfg = Release|Any CPU {0ED50CC0-F90F-44D4-830E-2F3BACE040EC}.Release|Any CPU.Build.0 = Release|Any CPU + {67D4F6C5-758D-489F-A100-8B259B2158D2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {67D4F6C5-758D-489F-A100-8B259B2158D2}.Debug|Any CPU.Build.0 = Debug|Any CPU + {67D4F6C5-758D-489F-A100-8B259B2158D2}.Release|Any CPU.ActiveCfg = Release|Any CPU + {67D4F6C5-758D-489F-A100-8B259B2158D2}.Release|Any CPU.Build.0 = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE diff --git a/Aplib.Tests/Aplib.Tests.csproj b/Aplib.Tests/Aplib.Tests.csproj new file mode 100644 index 00000000..67ed265b --- /dev/null +++ b/Aplib.Tests/Aplib.Tests.csproj @@ -0,0 +1,29 @@ + + + + net8.0 + enable + enable + + false + true + + + + + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + + + + + + + + diff --git a/Aplib.Tests/GlobalUsings.cs b/Aplib.Tests/GlobalUsings.cs new file mode 100644 index 00000000..8c927eb7 --- /dev/null +++ b/Aplib.Tests/GlobalUsings.cs @@ -0,0 +1 @@ +global using Xunit; \ No newline at end of file diff --git a/Aplib.Tests/SonarTest.cs b/Aplib.Tests/SonarTest.cs new file mode 100644 index 00000000..86f10414 --- /dev/null +++ b/Aplib.Tests/SonarTest.cs @@ -0,0 +1,13 @@ +namespace Aplib.Tests; + +public class SonarTest +{ + [Fact] + public void TestMain() + { + Core.SonarTest test = new(); + test.Main(); + + Assert.True(true); + } +} \ No newline at end of file From 702af1e92a6fba560e8e7ce7e0fd6fb99c694da9 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 15:15:59 +0100 Subject: [PATCH 10/17] fix: collect code coverage --- .github/workflows/pr-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index a05eb89c..50e5a6a3 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -46,5 +46,5 @@ jobs: .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" dotnet restore dotnet build - dotnet test + dotnet test --collect "Code Coverage" .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From 2ea1846bea9ff70db3670a12d629c289953c3dd4 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 15:22:18 +0100 Subject: [PATCH 11/17] fix: use dotnet-coverage --- .github/workflows/pr-build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 50e5a6a3..2971bce6 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -43,8 +43,8 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} shell: powershell run: | - .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" - dotnet restore - dotnet build - dotnet test --collect "Code Coverage" + dotnet tool install --global dotnet-coverage + .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml + dotnet build --no-incremental + dotnet-coverage collect "dotnet test" -f xml -o "coverage.xml" .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From 17b282eb4505e2e5efa12e7a2bdd4e6c4cc90719 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 15:41:35 +0100 Subject: [PATCH 12/17] Make individual tasks --- .github/workflows/pr-build.yml | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 2971bce6..a654efb9 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -37,14 +37,33 @@ jobs: run: | New-Item -Path .\.sonar\scanner -ItemType Directory dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner - - name: Build and analyze + - name: Install Coverage Tool + shell: powershell + run: | + dotnet tool install --global dotnet-coverage + - name: Prepare SonarCloud analysis env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} shell: powershell run: | - dotnet tool install --global dotnet-coverage - .\.sonar\scanner\dotnet-sonarscanner begin /k:"team-zomsa_aplib.net" /o:"team-zomsa" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml + .\.sonar\scanner\dotnet-sonarscanner begin \ + /k:"team-zomsa_aplib.net" /o:"team-zomsa" \ + /d:sonar.token="${{ secrets.SONAR_TOKEN }}" \ + /d:sonar.host.url="https://sonarcloud.io" \ + /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml + - name: Build the project + shell: powershell + run: | dotnet build --no-incremental + + - name: Test the project + shell: powershell + run: | dotnet-coverage collect "dotnet test" -f xml -o "coverage.xml" + - name: Run SonarCloud analysis + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + shell: powershell + run: | .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}" From ccb417be7d6bc7c16be2d19ada8745a556005c31 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 15:44:00 +0100 Subject: [PATCH 13/17] fix: multiline command --- .github/workflows/pr-build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index a654efb9..de660ab6 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -46,12 +46,12 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} shell: powershell - run: | - .\.sonar\scanner\dotnet-sonarscanner begin \ - /k:"team-zomsa_aplib.net" /o:"team-zomsa" \ - /d:sonar.token="${{ secrets.SONAR_TOKEN }}" \ - /d:sonar.host.url="https://sonarcloud.io" \ - /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml + run: > + .\.sonar\scanner\dotnet-sonarscanner begin + /k:"team-zomsa_aplib.net" /o:"team-zomsa" + /d:sonar.token="${{ secrets.SONAR_TOKEN }}" + /d:sonar.host.url="https://sonarcloud.io" + /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml - name: Build the project shell: powershell run: | From be1e6bbc8961c965923f8fafa483686512d137e2 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 16:51:33 +0100 Subject: [PATCH 14/17] Just write hello world for the test --- Aplib.Core/Main.cs | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/Aplib.Core/Main.cs b/Aplib.Core/Main.cs index 9a8b8fe3..6b871815 100644 --- a/Aplib.Core/Main.cs +++ b/Aplib.Core/Main.cs @@ -4,18 +4,6 @@ namespace Aplib.Core { public class SonarTest { - public void Main() - { - Console.WriteLine("Hello World!"); - int i = 0; - - while (i < 10) - { - Console.WriteLine(i); - i++; - } - - Console.WriteLine("i is 1"); - } + public void Main() => Console.WriteLine("Hello World!"); } } From c9023519e8f458d69fb3e45c774336ee6cace089 Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 16:52:35 +0100 Subject: [PATCH 15/17] Rename main file --- Aplib.Core/{Main.cs => SonarTest.cs} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Aplib.Core/{Main.cs => SonarTest.cs} (100%) diff --git a/Aplib.Core/Main.cs b/Aplib.Core/SonarTest.cs similarity index 100% rename from Aplib.Core/Main.cs rename to Aplib.Core/SonarTest.cs From 563528617bad9240964474c0d68f04fb9de6fd0e Mon Sep 17 00:00:00 2001 From: Joachim Dekker Date: Tue, 13 Feb 2024 17:43:16 +0100 Subject: [PATCH 16/17] Conform to Guido --- .github/workflows/pr-build.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index de660ab6..8e57fdfe 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -7,17 +7,15 @@ on: types: [opened, synchronize, reopened] jobs: build: - name: Build and analyze + name: Build .NET and Analyse with SonarCloud runs-on: windows-latest steps: - name: Set up JDK 17 uses: actions/setup-java@v3 with: java-version: 17 - distribution: 'zulu' # Alternative distribution options are available. + distribution: 'zulu' - uses: actions/checkout@v3 - with: - fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - name: Cache SonarCloud packages uses: actions/cache@v3 with: From b73f14724402b21c770c9571de301de55922c0a8 Mon Sep 17 00:00:00 2001 From: Joachim Dekker <51530837+joachimdekker@users.noreply.github.com> Date: Mon, 19 Feb 2024 10:22:48 +0100 Subject: [PATCH 17/17] style: conform to Quake Co-authored-by: Quake <74355598+QuakeEye@users.noreply.github.com> --- .github/workflows/pr-build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index 8e57fdfe..e580227f 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -54,7 +54,6 @@ jobs: shell: powershell run: | dotnet build --no-incremental - - name: Test the project shell: powershell run: |