Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify shouldUpdate to include TReference #73

Merged
merged 2 commits into from
Jun 23, 2024
Merged

feat: modify shouldUpdate to include TReference #73

merged 2 commits into from
Jun 23, 2024

Conversation

JensSteenmetz
Copy link
Member

@JensSteenmetz JensSteenmetz commented Jun 23, 2024 •
edited
Loading

BREAKING CHANGE: new parameter for shouldUpdate predicate

Description

This PR adds a TReference parameter to the shouldUpdate predicate.

Testability

Run tests.

Checklist

  • Set the proper pull request name
  • Merged main into your branch

@JensSteenmetz JensSteenmetz changed the base branch from main to dev June 23, 2024 16:50
@QuakeEye QuakeEye self-requested a review June 23, 2024 16:52
@JensSteenmetz JensSteenmetz changed the title feat!: modify shouldUpdate to include TReference feat: modify shouldUpdate to include TReference Jun 23, 2024
@JensSteenmetz JensSteenmetz changed the title feat: modify shouldUpdate to include TReference feat!: modify shouldUpdate to include TReference Jun 23, 2024
@JensSteenmetz JensSteenmetz changed the title feat!: modify shouldUpdate to include TReference feat: modify shouldUpdate to include TReference Jun 23, 2024
joachimdekker
joachimdekker approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, incredible addition!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

QuakeEye
QuakeEye reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

QuakeEye
QuakeEye approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@JensSteenmetz JensSteenmetz merged commit 5fd567c into dev Jun 23, 2024
2 checks passed
@JensSteenmetz JensSteenmetz deleted the feat/AP-190-modify-shouldupdate-to-include-treference branch June 23, 2024 17:20
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuakeEye QuakeEye QuakeEye approved these changes

@joachimdekker joachimdekker joachimdekker approved these changes

Assignees
No one assigned
Labels
released on @dev released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JensSteenmetz @joachimdekker @QuakeEye