Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pathfinding action #70

Merged
merged 8 commits into from
Jun 22, 2024
Merged

Conversation

joachimdekker
Copy link
Contributor

This PR adds the Pathfinding Action.

Testability

See the new tests.

Checklist

  • Set the proper pull request name
  • Merged main into your branch

Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left a few remarks

Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot a comment

Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
SilasPeters
SilasPeters previously approved these changes Jun 22, 2024
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Aplib.Extensions/Actions/PathfinderAction.cs Outdated Show resolved Hide resolved
Copy link

Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@joachimdekker joachimdekker merged commit 04d2fa9 into dev Jun 22, 2024
2 checks passed
@joachimdekker joachimdekker deleted the feat/add-pathfinding-action branch June 22, 2024 17:40
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants