Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ILoggable Interface #64

Merged
merged 9 commits into from
Jun 20, 2024
Merged

feat: add ILoggable Interface #64

merged 9 commits into from
Jun 20, 2024

Conversation

JoenvandeVorle
Copy link
Contributor

@JoenvandeVorle JoenvandeVorle commented Jun 13, 2024 •
edited
Loading

Description

Adds an ILoggable interface to all Bdi components and implements it, to allow for easier logging

Testability

There are unit tests for ILoggable

Checklist

  • Set the proper pull request name
  • Merged main into your branch

@JoenvandeVorle JoenvandeVorle self-assigned this Jun 13, 2024
@JoenvandeVorle JoenvandeVorle marked this pull request as ready for review June 14, 2024 08:15
@LukaBerkers LukaBerkers self-requested a review June 14, 2024 12:32
LukaBerkers
LukaBerkers requested changes Jun 14, 2024
View reviewed changes
Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
JensSteenmetz
JensSteenmetz requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at everything yet, but have some important comments.

Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
Aplib.Core/Desire/DesireSets/DesireSet.cs Show resolved Hide resolved
Aplib.Core/ILoggable.cs Outdated Show resolved Hide resolved
LukaBerkers
LukaBerkers requested changes Jun 14, 2024
View reviewed changes
Aplib.Core.Tests/ILoggableTests.cs Outdated Show resolved Hide resolved
Aplib.Core.Tests/ILoggableTests.cs Outdated Show resolved Hide resolved
Aplib.Core.Tests/ILoggableTests.cs Outdated Show resolved Hide resolved
@LukaBerkers
Copy link
Contributor

Nicely done, very clean implementation. I left only a few comments :)

LukaBerkers
LukaBerkers requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@LukaBerkers LukaBerkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more comments about the doc comments

Aplib.Core/Logging/ILoggable.cs Outdated Show resolved Hide resolved
Aplib.Core/Logging/ILoggable.cs Outdated Show resolved Hide resolved
LukaBerkers
LukaBerkers previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@LukaBerkers LukaBerkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

JensSteenmetz
JensSteenmetz requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have one question about the constructor of LogNode

Aplib.Core/Logging/LogNode.cs Show resolved Hide resolved
Aplib.Core/Logging/ILoggable.cs Outdated Show resolved Hide resolved
JensSteenmetz
JensSteenmetz requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing :)

Aplib.Core/Logging/LogNode.cs Outdated Show resolved Hide resolved
JensSteenmetz
JensSteenmetz requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion

Aplib.Core/Logging/LogNode.cs Outdated Show resolved Hide resolved
@JoenvandeVorle @JensSteenmetz
chore: update documentation
11b5539 
Co-authored-by: Jens Steenmetz <[email protected]>
JensSteenmetz
JensSteenmetz approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@JensSteenmetz JensSteenmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@JoenvandeVorle JoenvandeVorle enabled auto-merge (squash) June 20, 2024 17:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoenvandeVorle JoenvandeVorle merged commit df39f1b into dev Jun 20, 2024
2 checks passed
@JoenvandeVorle JoenvandeVorle deleted the feat/add-ILoggable branch June 20, 2024 19:11
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaBerkers LukaBerkers LukaBerkers approved these changes

@JensSteenmetz JensSteenmetz JensSteenmetz approved these changes

Assignees

@JoenvandeVorle JoenvandeVorle

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoenvandeVorle @LukaBerkers @JensSteenmetz