Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add teleporter logic and prefab #32

Merged
merged 19 commits into from
May 1, 2024

Conversation

SilasPeters
Copy link
Contributor

@SilasPeters SilasPeters commented Apr 12, 2024

Description

This PR introduces functional teleporters.

Testability

There is a testscene: TeleportLevel. This include an example on how to link two portals together.

Checklist

  • Set the proper pull request name
  • Merged main into your branch
  • Added a scene to the game for your changes

@SilasPeters SilasPeters self-assigned this Apr 12, 2024
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from 8c7693d to 7243514 Compare April 12, 2024 20:33
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from 7243514 to 7e44924 Compare April 12, 2024 20:35
@SilasPeters SilasPeters marked this pull request as ready for review April 12, 2024 20:37
@SilasPeters SilasPeters changed the base branch from main to feat/0078-spawn-teleporters April 12, 2024 20:37
@SilasPeters SilasPeters changed the base branch from feat/0078-spawn-teleporters to main April 13, 2024 09:48
@SilasPeters SilasPeters marked this pull request as draft April 13, 2024 09:49
@SilasPeters SilasPeters marked this pull request as ready for review April 13, 2024 11:05
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from f7b5a33 to b47a46b Compare April 13, 2024 11:26
Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool. Left a few comments.

aplib.net-demo/Assets/Scenes/MouseLock.unity Outdated Show resolved Hide resolved
aplib.net-demo/Assets/Scripts/Teleporter/Teleporter.cs Outdated Show resolved Hide resolved
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from 10fe688 to 9565cb2 Compare April 24, 2024 10:22
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from 22a1f65 to 9565cb2 Compare April 24, 2024 10:58
SSelinn
SSelinn previously approved these changes Apr 24, 2024
Copy link
Collaborator

@SSelinn SSelinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@SilasPeters
Copy link
Contributor Author

@SSelinn great! I will merge main now, can you approve again afterwards? @joachimdekker you too?

@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from b234f37 to 9565cb2 Compare April 24, 2024 12:07
@SilasPeters
Copy link
Contributor Author

@joachimdekker @SSelinn it should now work properly after merging!

Thank god for git reset, or I would have lost so much time

Copy link
Contributor

@joachimdekker joachimdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you write an aplib test for this?

@SilasPeters
Copy link
Contributor Author

Did you write an aplib test for this?

@joachimdekker I certainly did just now!

@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch 2 times, most recently from 9fd9ed0 to ee56574 Compare April 29, 2024 13:59
@SilasPeters SilasPeters force-pushed the feat/0078-spawn-teleporters---teleporter-prefab branch from ee56574 to fc5375b Compare April 29, 2024 14:10
JoenvandeVorle
JoenvandeVorle previously approved these changes Apr 29, 2024
Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@QuakeEye QuakeEye self-requested a review May 1, 2024 11:33
@QuakeEye QuakeEye self-requested a review May 1, 2024 12:11
Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@JoenvandeVorle JoenvandeVorle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SilasPeters SilasPeters merged commit eeccfdc into main May 1, 2024
2 checks passed
@SilasPeters SilasPeters deleted the feat/0078-spawn-teleporters---teleporter-prefab branch May 1, 2024 14:37
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants