-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add teleporter logic and prefab #32
feat: add teleporter logic and prefab #32
Conversation
8c7693d
to
7243514
Compare
7243514
to
7e44924
Compare
f7b5a33
to
b47a46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool. Left a few comments.
10fe688
to
9565cb2
Compare
22a1f65
to
9565cb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
@SSelinn great! I will merge main now, can you approve again afterwards? @joachimdekker you too? |
b234f37
to
9565cb2
Compare
@joachimdekker @SSelinn it should now work properly after merging! Thank god for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you write an aplib test for this?
@joachimdekker I certainly did just now! |
aplib.net-demo/Assets/Prefabs/Player/Player - TeleportLevel.prefab
Outdated
Show resolved
Hide resolved
aplib.net-demo/Assets/Scenes/TestScenes/TeleporterTestScene.unity
Outdated
Show resolved
Hide resolved
9fd9ed0
to
ee56574
Compare
ee56574
to
fc5375b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…orters---teleporter-prefab
aplib.net-demo/Assets/Prefabs/Player/Player - TeleportLevel.prefab
Outdated
Show resolved
Hide resolved
aplib.net-demo/Assets/Scenes/TestScenes/TeleporterTestScene.meta
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 3.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR introduces functional teleporters.
Testability
There is a testscene:
TeleportLevel
. This include an example on how to link two portals together.Checklist