Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ranged enemy animations #100

Merged
merged 15 commits into from
Jun 19, 2024

Conversation

JoenvandeVorle
Copy link
Contributor

@JoenvandeVorle JoenvandeVorle commented Jun 17, 2024

Description

Add idle, walking, loading, and shooting animations to the ranged enemy.

Also fixes-a two bugs: The melee weapon hitbox no moves around based on the melee animation, and the double damage bug for ranged enemies is also fixed.

Also moved some navmesh folders into the archived folder

Testability

Go to AddRangedAnimations in the archived scenes folder. In there you will find a respawning ranged enemy that does 0 damage, so you can see all the animations there.

Checklist

  • Set the proper pull request name
  • Merged main into your branch
  • Added a scene to the game for your changes

@JoenvandeVorle JoenvandeVorle self-assigned this Jun 17, 2024
@JoenvandeVorle JoenvandeVorle changed the title feat: add rangedenemy animations feat: add ranged enemy animations Jun 17, 2024
SSelinn
SSelinn previously approved these changes Jun 17, 2024
Copy link
Collaborator

@SSelinn SSelinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SSelinn
SSelinn previously approved these changes Jun 17, 2024
Copy link
Collaborator

@SSelinn SSelinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeye

Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the previous comment all is well

Copy link
Contributor

@QuakeEye QuakeEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

Copy link
Collaborator

@SSelinn SSelinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeye!

@JoenvandeVorle JoenvandeVorle merged commit 796cfb5 into main Jun 19, 2024
3 checks passed
@JoenvandeVorle JoenvandeVorle deleted the feat/AP-160-add-rangedenemy-animations branch June 19, 2024 14:22
Copy link

🎉 This PR is included in version 3.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants