Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Re-assess GeoOrigin terms for inclusion in first draft #425

Closed
essvee opened this issue Nov 4, 2022 · 5 comments
Closed

Re-assess GeoOrigin terms for inclusion in first draft #425

essvee opened this issue Nov 4, 2022 · 5 comments
Assignees
Labels
review Changes to be made following feedback from internal reviewers

Comments

@essvee
Copy link
Contributor

essvee commented Nov 4, 2022

I would think that Countries and States would be more useful than continent in a collection description (especially for those that are more specific than "global"). I'm surprised they are not options under this class.

Originally posted by @Jegelewicz in #131 (comment)

@essvee essvee self-assigned this Nov 4, 2022
@essvee
Copy link
Contributor Author

essvee commented Nov 4, 2022

For discussion at the next WG session (10-11-22):
Suggest we re-assess which GeoOrigin terms we're including in the first release: at the moment it's just continent, locality, salinityType, region, waterBody and waterBodyType, but a bunch of the other terms look to be complete (list below). Is it worth adding them into the first batch? They're mostly lifted from dwc so other folks will probably be expecting to see something equivalent at the collection level...

#137 islandGroup
#138 island
#139 country
#140 countryCode
#141 stateProvince
#142 county
#143 municipality
#225 ecoRegion

@essvee essvee added the review Changes to be made following feedback from internal reviewers label Nov 4, 2022
@rondlg
Copy link
Contributor

rondlg commented Nov 10, 2022

See #141 and #142 - use political divisions instead of baking in actual ranks to the term names. This lets the hierarchy grow without restriction and can be used in tandem with a rank field to allow the use of broader vocabularies.

-- politicalDivision0 -> continent
-- politicalDivision1 -> country
-- politicalDivision2 -> "whatever you want it to be"
-- politicalDivision3 -> "whatever you want it to be"

@jbstatgen
Copy link
Collaborator

Better late than never ...

On Tab "Registry_openDA_collection" of the "Registry_Vocabularies" spreadsheet file you can find the "Geographic region" schema from the SYNTHESYS+ report (Tilley 2019) for the Collection Digitization Dashboard.

As a first guess,
Level 1 (aka 'GeographicSphere' by me) := missing in ltc:GeographicOrigin
Level 2 (GeographicCategory) := ltc:continent (mmh, scale also required for oceans ...)
Level 3 (GeographicSubcategory):= ltc:region (here: SYNTHESYS+ provides only subdivisions in the Atlantic and Pacific)

@essvee
Copy link
Contributor Author

essvee commented Nov 24, 2022

Partially addressed by PR #428, but I'm leaving it open until someone reminds me whether ecoRegion (#225) is included or not - the ecoRegion term-level issue isn't tagged with 'done' so it might need another look.

Will break out the renaming of stateProvince and county as flagged by @rondlg into another issue and make any ensuing changes separately to keep things simpler and easier to trace.

@essvee
Copy link
Contributor Author

essvee commented Nov 30, 2022

Working Group decision following discussion: Include ecoRegion in first draft, see notes from 30/11/2022

@essvee essvee closed this as completed Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review Changes to be made following feedback from internal reviewers
Projects
None yet
Development

No branches or pull requests

4 participants