Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should sourceMappingURL be preserved? #692

Closed
Marzal opened this issue May 1, 2024 · 3 comments
Closed

should sourceMappingURL be preserved? #692

Marzal opened this issue May 1, 2024 · 3 comments

Comments

@Marzal
Copy link

Marzal commented May 1, 2024

Hi, newcomer to minify and CSS in general.

I'm playing with hugo and when using minify I get /*# sourceMappingURL=main.css.map */ removed from the last line.

I'm not sure if minify should treat this line as a especial case and keep it.

Thanks for this great project!

Resources:
https://firefox-source-docs.mozilla.org/devtools-user/debugger/how_to/use_a_source_map/index.html
https://developer.chrome.com/blog/sourcemappingurl-and-sourceurl-syntax-changed
https://sourcemaps.info/spec.html

@tdewolff
Copy link
Owner

tdewolff commented May 2, 2024

Thanks David, this has been implemented for CSS!

@Marzal
Copy link
Author

Marzal commented May 2, 2024

Thanks, that was a quick response 👍

@mschfh
Copy link

mschfh commented Jul 21, 2024

Hi,

This change more than doubled the "minified" CSS size.

IMHO this should be stripped by default, if someone requires it for development purposes, they can disable minification (e.g. remove --minify from Hugo args)

Please disable this again and/or implement a switch to toggle this behaviour. 🙏

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants