remove observable calls to "from" #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 95.73% 95.75% +0.02%
==========================================
Files 19 19
Lines 11143 11129 -14
Branches 1804 1801 -3
==========================================
- Hits 10668 10657 -11
+ Misses 472 469 -3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljharb
reviewed
Mar 5, 2021
| 1. If Type(_item_) is Object, then | ||
| 1. If ? HasProperty(_item_, *"timeZone"*) is *false*, return _item_. | ||
| 1. Set _item_ to ? Get(_item_, *"timeZone"*). | ||
| 1. If Type(_item_) is Object and ? HasProperty(_item_, *"timeZone"*) is *false*, return _item_. |
ptomato
approved these changes
Mar 6, 2021
polyfill/test/PlainDateTime/constructor/constructor/order-of-operations.js
Show resolved
Hide resolved
This commit removes observable "from" lookups for `Calendar` and `TimeZone` from the spec and the polyfill, in response to the delegate reviews. Refs: tc39#1293
`from` methods can no longer be monkey-patched, so this commit removes that behavior from the cookbook documentation.
ryzokuken
force-pushed
the
review/observable-from
branch
from
ba3dbd9
to
f529165
Compare
ryzokuken
force-pushed
the
review/observable-from
branch
from
f529165
to
671d3eb
Compare
The polyfill no longer does observable `from` lookups for `Calendar` and `TimeZone`. Therefore, this commit removes tests that check that behavior and modifies those that merely rely on it.
ryzokuken
force-pushed
the
review/observable-from
branch
from
671d3eb
to
20eae59
Compare
ryzokuken
force-pushed
the
review/observable-from
branch
from
20eae59
to
955c9d2
Compare
ptomato
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1293
/cc @ptomato @ljharb