Fix debug properties to not call toString()

This avoids making an observable call into the type's toString() method in its constructor. The ZonedDateTime version was additionally missing a parameter.
tc39 · Nov 2, 2020 · e5389e2 · e5389e2
1 parent 2c197e7
commit e5389e2
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 9 deletions.
diff --git a/polyfill/lib/calendar.mjs b/polyfill/lib/calendar.mjs
@@ -16,7 +16,7 @@ export class Calendar {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${id}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/date.mjs b/polyfill/lib/date.mjs
@@ -50,7 +50,7 @@ export class Date {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${TemporalDateToString(this)}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/datetime.mjs b/polyfill/lib/datetime.mjs
@@ -104,7 +104,7 @@ export class DateTime {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${DateTimeToString(this, 'auto')}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/duration.mjs b/polyfill/lib/duration.mjs
@@ -74,7 +74,7 @@ export class Duration {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${ES.TemporalDurationToString(this)}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/monthday.mjs b/polyfill/lib/monthday.mjs
@@ -49,7 +49,7 @@ export class MonthDay {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${MonthDayToString(this)}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/time.mjs b/polyfill/lib/time.mjs
@@ -70,7 +70,7 @@ export class Time {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${TemporalTimeToString(this, 'auto')}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/timezone.mjs b/polyfill/lib/timezone.mjs
@@ -37,7 +37,7 @@ export class TimeZone {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${timeZoneIdentifier}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/yearmonth.mjs b/polyfill/lib/yearmonth.mjs
@@ -48,7 +48,7 @@ export class YearMonth {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${this}>`,
+        value: `${this[Symbol.toStringTag]} <${YearMonthToString(this)}>`,
         writable: false,
         enumerable: false,
         configurable: false

diff --git a/polyfill/lib/zoneddatetime.mjs b/polyfill/lib/zoneddatetime.mjs
@@ -44,7 +44,7 @@ export class ZonedDateTime {
 
     if (typeof __debug__ !== 'undefined' && __debug__) {
       Object.defineProperty(this, '_repr_', {
-        value: `${this[Symbol.toStringTag]} <${zonedDateTimeToString(this)}>`,
+        value: `${this[Symbol.toStringTag]} <${zonedDateTimeToString(this, 'auto')}>`,
         writable: false,
         enumerable: false,
         configurable: false