Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Rendered spec is out of date #40

Open
rwaldron opened this issue Aug 6, 2018 · 6 comments
Open

Rendered spec is out of date #40

rwaldron opened this issue Aug 6, 2018 · 6 comments

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Aug 6, 2018

Please make sure that https://tc39.github.io/proposal-private-methods/ is up to date with the latest spec changes.

@littledan
Copy link
Member

Could you be specific as what you see as being out of date? I have a Travis-CI script set up that tries to rebuild the spec, and it looks like it was rebuilt with the most recent change that landed.

@rwaldron
Copy link
Contributor Author

rwaldron commented Aug 8, 2018

Maybe it's not a matter of being out of date? Maybe it's an issue with the markup itself? Maybe the css?

Incidentally, when I build this locally and view it in a browser, the rendered spec looks very different from what's shown from gh-pages:

@littledan
Copy link
Member

Oh, maybe the script is using a bad ecmarkup version or something. The thing is, the changes from recent patches like #39 definitely show up. I'll look into this; thanks for raising the issue.

@caiolima
Copy link
Collaborator

The diff now is being generated by ecma262-compare on https://arai-a.github.io/ecma262-compare/?pr=1668. Does this addresses such issue?

@ljharb
Copy link
Member

ljharb commented Mar 31, 2021

That link won’t live forever like this proposal, once archived, will - it still seems ideal to keep individual proposal repos up to date for significant changes prior to stage 4.

@littledan
Copy link
Member

Let's work on fixing any issues with keeping those links alive or archiving their contents somewhere, rather than going back through the work of fixing the manual diff (which is a place that's easy to continue making mistakes).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants