Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

toMap and toSet #125

Closed
Jack-Works opened this issue Feb 4, 2021 · 4 comments
Closed

toMap and toSet #125

Jack-Works opened this issue Feb 4, 2021 · 4 comments

Comments

@Jack-Works
Copy link
Member

Just like toArray, I think we should have it. Not too late before we go to the stage 3

@bakkot
Copy link
Collaborator

bakkot commented Feb 4, 2021

See previous discussion in e.g. #36 (comment) and #17.

Personally I don't think anything other than toArray should be in this proposal. The problem of constructing collections in general is a much larger space; as mentioned in the above-linked comment, Array really is uniquely privileged in a way that Map and Set are not.

(Also, I'm not convinced that Stage 2 is an appropriate time to add new methods. The major semantics are supposed to be settled at this point.)

@Jack-Works
Copy link
Member Author

fine though I think it is very useful to make us map on a Map or something

@ljharb
Copy link
Member

ljharb commented Feb 4, 2021

I agree, but that’s what follow up proposals are for.

@devsnek
Copy link
Member

devsnek commented Feb 4, 2021

we are past the point of adding new methods, and have been for several months.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants