Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .name? #495

Closed
rauschma opened this issue Jan 27, 2023 · 1 comment
Closed

Rename .name? #495

rauschma opened this issue Jan 27, 2023 · 1 comment

Comments

@rauschma
Copy link

I’m only bringing this up because I noticed that the API may be changed slightly. That may be an opportunity to also make this small improvement:

 type DecoratorContext = {
-  name: string | symbol;
+  key: string | symbol;
   // ···
 }
@pzuraq
Copy link
Collaborator

pzuraq commented Jan 27, 2023

Part of the reasoning for name was that the human readable private name of a private field, which is not a key, is also in this field when present. The other API change also has a DX benefit, whereas this would just be updating to a new field, so I don't think this is a very well motivated change personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants