Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt AbortController from DOM spec? #19

Closed
felixfbecker opened this issue Apr 18, 2018 · 2 comments
Closed

Adopt AbortController from DOM spec? #19

felixfbecker opened this issue Apr 18, 2018 · 2 comments

Comments

@felixfbecker
Copy link

felixfbecker commented Apr 18, 2018

Now that fetch is abortable and there are the globals AbortController and AbortSignal, should this proposal simply adopt that spec? For sure it wouldn't be ideal to have both AbortSignal and CancellationToken. But the sooner this could be speced outside of DOM the sooner we could get the types in Node, which means libraries and core APIs can rely on it for cancellation support

https://dom.spec.whatwg.org/#interface-abortcontroller
https://fetch.spec.whatwg.org/#dom-request-signal

@ikokostya
Copy link

ikokostya commented Apr 18, 2018

See #16 and #17

@rbuckton
Copy link
Collaborator

AbortController/AbortSignal has a strong dependency on EventTarget.

I'm closing this issue as the proposal no longer specifies cancellation behavior. See #22 for the current thinking regarding cancellation and interoperability with AbortController/AbortSignal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants