-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage 2 tracking #3
Comments
Before stage 2 advancement, I believe this proposal needs to answer these unanswered questions:
|
@ljharb good questions, I'll look into answering them |
There's additional information that's relevant to this proposal in this thread: tc39/ecma262#395 I wasn't sure where to link it :-) |
Certainly we need the ability to provide a means for a fallback implementation for missing built-in modules. There is possible the case for a built-in module with a known bug. @ljharb, please describe in more detail the other polypill use cases. |
and even, adding my own custom module for, for example, importing all my company’s internal modules without needing to use URLs (something import maps allows in the one browser it’s in) |
The first part of this ones the missing functionality.
Couldn't this be handled by creating your own module that imports the builtin Temporal, subclasses it and then exports the subclass as Temporal?
This is handling a known bug case. This could be handled with a package name map like functionality and then providing a module that imports the builtin, subclasses and fixes it and then exports the subclass.
This is a specific instance of the "known bug" case.
I think that capability is beyond the scope of this proposal. |
Re subclassing/wrapping, I can certainly do that, but the point is that i want all dependencies - code i don’t control - to get my version of Temporal, and to prevent any access to the original one. Similarly, by fixing, i need code that doesn’t know about the bug or my fix to silently get my fixed version when they ask for the original one, just like i can do now with globals. The last part may be directly beyond the scope of the proposal, but i think it falls out naturally from the other requirements, which imo are both in scope and also stage 2 requirements. |
This proposal reached stage 1 at the July 2018 meeting and this issue will track progress towards stage 2.
Requirements:
The text was updated successfully, but these errors were encountered: