From 689d0d4814449422537b4abf6e978d67408eb3a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=2E=C2=A0S=2E=C2=A0Choi?= <jschoi@jschoi.org>
Date: Thu, 21 Dec 2023 10:52:26 -0700
Subject: [PATCH] fix: Replace IteratorStep with NextMethod (#44)

Fixes #33.
Prevents an infinite loop caused by IteratorStep(iteratorRecord) not actually flagging termination when IteratorRecord is async. Instead, we will directly call iteratorStep.[[NextMethod]], like how `for await` does.

Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
---
 spec.html | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/spec.html b/spec.html
index d958d54..a09f523 100644
--- a/spec.html
+++ b/spec.html
@@ -93,8 +93,11 @@ <h1><ins>Array.fromAsync ( _asyncItems_ [ , _mapfn_ [ , _thisArg_ ] ] )</ins></h
                   1. Let _error_ be ThrowCompletion(a newly created *TypeError* object).
                   1. Return ? AsyncIteratorClose(_iteratorRecord_, _error_).
                 1. Let _Pk_ be ! ToString(𝔽(_k_)).
-                1. Let _next_ be ? Await(IteratorStep(_iteratorRecord_)).
-                1. If _next_ is *false*, then
+                1. Let _nextResult_ be ? Call(_iteratorRecord_.[[NextMethod]], _iteratorRecord_.[[Iterator]]).
+                1. Set _nextResult_ to ? Await(_nextResult_).
+                1. If _nextResult_ is not an Object, throw a *TypeError* exception.
+                1. Let _done_ be ? IteratorComplete(_nextResult_).
+                1. If _done_ is *true*,
                   1. Perform ? Set(_A_, *"length"*, 𝔽(_k_), *true*).
                   1. Return Completion Record { [[Type]]: ~return~, [[Value]]: _A_, [[Target]]: ~empty~ }.
                 1. Let _nextValue_ be ? IteratorValue(_next_).