Editorial: change [[localeMatcher]] to [[LocaleMatcher]] to align w/ 262 #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
reviewed
Mar 15, 2023
| @@ -203,7 +203,7 @@ <h1>Internal slots</h1> | |||
| [[LocaleData]].[[<_locale_>]].[[hc]] must be « *null*, *"h11"*, *"h12"*, *"h23"*, *"h24"* ». | |||
| </li> | |||
| <li> | |||
| [[LocaleData]].[[<_locale_>]].[[hourCycle]] must be a String value equal to *"h11"*, *"h12"*, *"h23"*, or *"h24"*. | |||
There was a problem hiding this comment.
This one seems to be imbalanced. I suppose there is an access to this [[hourCycle]] field that needs to be updated too?
There was a problem hiding this comment.
Correct. I've got a forthcoming PR with all of the relevant fields capitalized
There was a problem hiding this comment.
generally every commit landed to main needs to be correct, so it might need to all go in the same PR
|
@ben-allen This is editorial, correct? Please say so in the PR title |
ben-allen
changed the title
|
@ben-allen why is this closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(very) partial fix #81 . this one does not seem to be exposed to [[<dynamic>]] access problems. submitted to get reality check on my judgement here.