Normative: Make SharedArrayBuffer's sole parameter required #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
added
the
needs consensus
ljharb
added
normative change
michaelficarra
approved these changes
Apr 27, 2021
devsnek
reviewed
May 25, 2021
ljharb
added
has consensus
|
Test262 already reflects web reality, so no change is required there. |
bakkot
approved these changes
May 29, 2021
bakkot
added
the
ready to merge
SharedArrayBuffer.length is 1 on all web engines (as is ArrayBuffer.length). Unsure why this was made optional. eshost output for `print(SharedArrayBuffer.length)`: ``` 1 1 1 1 ```
ljharb
force-pushed
the
required-sab-param
branch
from
f931795
to
c2a9389
Compare
jugglinmike
added a commit
to bocoup/proposal-resizablearraybuffer
that referenced
this pull request
Jul 13, 2021
Explicitly specify the value that should be used when optional parameters are not provided. Update some function signatures to highlight the modifications included in this proposal. Additionally, update the signature of the SharedArrayBuffer constructor to reflect a recent change in ECMA262 [1]. [1] tc39/ecma262#2393
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
SharedArrayBuffer.length is 1 on all web engines (as is ArrayBuffer.length). Unsure why this was made optional. eshost output for `print(SharedArrayBuffer.length)`: ``` 1 1 1 1 ```
ljharb
pushed a commit
that referenced
this pull request
Mar 2, 2022
ljharb
pushed a commit
that referenced
this pull request
Mar 2, 2022
ljharb
pushed a commit
that referenced
this pull request
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedArrayBuffer.length is 1 on all web engines (as is
ArrayBuffer.length). Unsure why this was made optional.
eshost output for
print(SharedArrayBuffer.length):