Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec text to be compatible with WebCrypto #2

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rbuckton
Copy link
Collaborator

@rbuckton rbuckton commented Feb 6, 2020

This Draft PR is intended to explore the possibility of devising a crypto global that would be compatible with the Web Cryptography API, such that web hosts could extend the API to encompass the full Web Cryptography API without issues with compatibility.

@bmeck
Copy link
Member

bmeck commented Feb 6, 2020

be aware that the default node repl exposes builtin modules as globals and crypto is the name of one of them.

$ echo 'typeof globalThis.crypto' | node -i
Welcome to Node.js v12.13.1.
Type ".help" for more information.
> typeof globalThis.crypto
'object'

@rbuckton
Copy link
Collaborator Author

rbuckton commented Feb 6, 2020

I am aware, and mentioned that during the meeting as well.

@ljharb
Copy link
Member

ljharb commented Feb 6, 2020

I don't think there's much of a concern with breaking this feature of node's repl, tho, is there?

@bmeck
Copy link
Member

bmeck commented Feb 6, 2020

I have no opinion on breakage, just want to keep it recorded as being thought about.

@rbuckton
Copy link
Collaborator Author

rbuckton commented Feb 6, 2020

@bmeck I made your comment into an issue so that we can ensure we track this and follow up with someone from Node about concerns and possible remediations.

@bakkot

This comment has been minimized.

@rbuckton
Copy link
Collaborator Author

rbuckton commented Feb 6, 2020

I don't believe this to be a web compatibility issue, however. Not throwing an error shouldn't make any existing code break today, though it would be worthwhile to discuss this more with someone directly involved with the WebCrypto spec about maintaining compatibility.

@rbuckton
Copy link
Collaborator Author

rbuckton commented Feb 6, 2020

@bakkot I've also made your comment above a separate issue so that we can track the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants