-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec text to be compatible with WebCrypto #2
base: master
Are you sure you want to change the base?
Conversation
be aware that the default node repl exposes builtin modules as globals and $ echo 'typeof globalThis.crypto' | node -i
Welcome to Node.js v12.13.1.
Type ".help" for more information.
> typeof globalThis.crypto
'object' |
I am aware, and mentioned that during the meeting as well. |
I don't think there's much of a concern with breaking this feature of node's repl, tho, is there? |
I have no opinion on breakage, just want to keep it recorded as being thought about. |
@bmeck I made your comment into an issue so that we can ensure we track this and follow up with someone from Node about concerns and possible remediations. |
This comment has been minimized.
This comment has been minimized.
I don't believe this to be a web compatibility issue, however. Not throwing an error shouldn't make any existing code break today, though it would be worthwhile to discuss this more with someone directly involved with the WebCrypto spec about maintaining compatibility. |
This Draft PR is intended to explore the possibility of devising a
crypto
global that would be compatible with the Web Cryptography API, such that web hosts could extend the API to encompass the full Web Cryptography API without issues with compatibility.