Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cockroachdb/cockroach
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tbg/cockroach
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: restore-8tb-more-ebs-bandwidth
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 20, 2023

  1. roachtest: use m5, not m5d, for restore 8tb test

    This works around #98783:
    
    ```
    Instance type
    c5.2xlarge
    ```
    
    Now the roachtest runs on standard EBS volumes (provisioned to 125mb/s,
    i.e. pretty weak ones):
    
    ```
    $ df -h /mnt/data1/
    Filesystem      Size  Used Avail Use% Mounted on
    /dev/nvme1n1    2.0T  4.0G  2.0T   1% /mnt/data1
    $ sudo nvme list | grep nvme1n1
    /dev/nvme1n1     vol065ed9110066bb362 Amazon Elastic Block Store               1           2.15  TB /   2.15  TB    512   B +  0 B   1.0
    ```
    
    Let's see how this fares.
    
    The theory is that the test previously failed failed due to RAID0
    because some nodes would unpredictably be slower than others (depending
    on the striping, etc, across the raided inhomogeneous volumes), which we
    don't handle well. Now, there's symmetry and hopefully things will be
    slower (since we only have 125mb/s per volume now) but functional, i.e.
    no more OOMs.
    
    I verified this via
    
    ```
    ./pkg/cmd/roachtest/roachstress.sh -c 10 restore/tpce/8TB/aws/nodes=10/cpus=8 -- --cloud aws --parallelism 1
    ```
    
    Epic: CRDB-25503
    Release note: None
    tbg committed Mar 20, 2023
    Copy the full SHA
    abd6420 View commit details
Loading