From 1b2f6cbbd23f3409bbeaf5027da8efd614fc3991 Mon Sep 17 00:00:00 2001 From: Tobias Schottdorf Date: Fri, 19 Oct 2018 13:16:17 +0200 Subject: [PATCH] storage: remove logging on GC suggestion These are expected during regular rebalancing activity and they can get quite spammy, see for example: https://github.com/cockroachdb/cockroach/issues/31622 Release note: None --- pkg/storage/store.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/storage/store.go b/pkg/storage/store.go index 107506c3a65e..3967437c2e4c 100644 --- a/pkg/storage/store.go +++ b/pkg/storage/store.go @@ -3781,8 +3781,6 @@ func (s *Store) HandleRaftResponse(ctx context.Context, resp *RaftMessageRespons if _, err := s.replicaGCQueue.Add(repl, replicaGCPriorityRemoved); err != nil { log.Errorf(ctx, "unable to add to replica GC queue: %s", err) - } else { - log.Infof(ctx, "added to replica GC queue (peer suggestion)") } case *roachpb.RaftGroupDeletedError: if replErr != nil { @@ -3800,8 +3798,6 @@ func (s *Store) HandleRaftResponse(ctx context.Context, resp *RaftMessageRespons // proper check. if _, err := s.replicaGCQueue.Add(repl, replicaGCPriorityDefault); err != nil { log.Errorf(ctx, "unable to add to replica GC queue: %s", err) - } else { - log.Infof(ctx, "added to replica GC queue (contacted deleted peer)") } case *roachpb.StoreNotFoundError: log.Warningf(ctx, "raft error: node %d claims to not contain store %d for replica %s: %s",