-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin drop-down-list. Descriptions. Servo block bug. and tiny stuff #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc1c87e.
Analog and Digital
"do" changes to "loop" like other blocks
Analog Pin list colours dark to distinguish from Digital Pin List
PWM pin list darker to distinguish other pin lists
Sometimes used as digital pins on UNO but best avoided
Move Delay blocks back to Control draw - My fault! When that happened! remove df_servo and df_360_degree_rotation_motor from core "Pins" draw Comment warning "Invalid Drawer: trying to add a drawer that already exists: DFRobot" Move dht11 blocks into "Generic Hardware" Remove Ultra sonic from Draw "Pins". Already in "Generic Hardware" Moved blocks DDRA PORTA PORT_FIX PINA to DuinoEDU as you need that hardware to use them. Give correct pinList to Toggle Pin block.
See issue taweili#149 ??Comment?? asking about attempt to treat constants differently from variables
This was referenced Mar 29, 2016
Closed
Stop treating numberblocks as a special case. See issue taweili#153 InputPullup. Correct socket type so it can be used. Toggle that works with variables and maths denoting pin number.
Because I really don't like the default layout / Look and feel. My prefered look will generally be in Skin/slim. Copy the files out of Skin/xxx up to the 'block' folder and clean/ re-compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really, really, really like KarlTH idea of drop down lists for pins! I think they deserve improving and not hidden away in one ‘manufacturers draw’.
This edit extends that idea and …
Creates new pinLists in the main body of the code (DueinoEDU pinLists remain for compatibility and because manufacturers draws should only be edited by them? - for compatibility)
Provides different lists for different kinds of pins (Digital, Analogue, PWM) on different boards
Standard blocks not in a special ‘manufacturers draw’ use new pinLists. Blocks in ‘manufacturers draw’ remain unchanged (by me).
Restores Servo block checking for valid integer constant at compile time. See issue #145
Revert to previous DigitalOutputBlock. See issue #149
Also…
Add image for Ultrasonic distance sensor hardware.
Multiple pop-up description improvements and name changes for consistency.
NOTE: Loop block socket says “loop” not “do” – some may not like this? But it is consistent