Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the padding for century and decade pages #10

Open
parslie opened this issue Sep 7, 2022 · 7 comments
Open

Fix the padding for century and decade pages #10

parslie opened this issue Sep 7, 2022 · 7 comments

Comments

@parslie
Copy link
Contributor

parslie commented Sep 7, 2022

The index page has padding, but none of the century or decade pages do. This should be fixed, so that the style of the site is cohesive.

@kritiag20
Copy link

I would like to work on this issue

@tavro
Copy link
Owner

tavro commented Oct 7, 2022

@kritiag20 sounds great, do so! 👍

@kritiag20
Copy link

Thanks @tavro

@kritiag20
Copy link

Hi @tavro can you explain me more about the issue
Screenshot (38)
have to fix the padding and alignment in this page?

@parslie
Copy link
Contributor Author

parslie commented Oct 7, 2022

@kritiag20 I can answer this!

I don't think this is an issue with pages for single years, like the one in the image above, but only pages for centuries and decades.

If you zoom in on the index page vs. any century/decade page, you can see that the padding is different horizontally. In the bottom image the text reaches further right and there's no space between the timeline and the edge on the left, unlike the top image.

On desktop the padding looks fine when not zoomed in, but it's still an issue when on mobile.

Century-Page-Padding

Decade-Page-Padding

@tavro
Copy link
Owner

tavro commented Oct 7, 2022

@parslie great answer, thank you!

@kritiag20
Copy link

Okay Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants