Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove extra soft prompt asking for media permission on every app launch in macOS #694

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

morajabi
Copy link
Contributor

@morajabi morajabi commented Sep 16, 2022

Fixes tauri-apps/tauri#4750

Discord conversation: https://discord.com/channels/616186924390023171/731495028677148753/1020299521542082610

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@morajabi morajabi requested a review from a team as a code owner September 16, 2022 14:56
amrbashir
amrbashir previously approved these changes Sep 29, 2022
@FabianLars
Copy link
Member

Do we need some kind of macos version check? idk if this can cause panics otherwise 🤔

@amrbashir
Copy link
Member

yeah this could probably panic, we need to test it on macOS 11 and below before merging

@lucasfernog
Copy link
Member

I believe this won't crash on macOS below 12 since we're only adding a method, but I can double check.

Should we add a config for this instead of always allowing it?

@amrbashir
Copy link
Member

Is there a security implications? otherwise it should be fine until someone asks for it to be configurable.

Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not crash on macOS 10.15 so it should be fine :)

@amrbashir amrbashir merged commit 8aa7d61 into tauri-apps:dev Sep 29, 2022
@github-actions github-actions bot mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Soft Prompts on launch
4 participants