-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove extra soft prompt asking for media permission on every app launch in macOS #694
Conversation
Do we need some kind of macos version check? idk if this can cause panics otherwise 🤔 |
yeah this could probably panic, we need to test it on macOS 11 and below before merging |
I believe this won't crash on macOS below 12 since we're only adding a method, but I can double check. Should we add a config for this instead of always allowing it? |
Is there a security implications? otherwise it should be fine until someone asks for it to be configurable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not crash on macOS 10.15 so it should be fine :)
Fixes tauri-apps/tauri#4750
Discord conversation: https://discord.com/channels/616186924390023171/731495028677148753/1020299521542082610
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information