Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-export url::Url #612

Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: re-export url::Url #612

merged 1 commit into from
Jun 17, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team June 15, 2022 11:28
@amrbashir amrbashir requested a review from a team as a code owner June 15, 2022 11:28
@wusyong wusyong merged commit 0cb6961 into dev Jun 17, 2022
@wusyong wusyong deleted the reexport-url branch June 17, 2022 04:53
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jun 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiya01 keiya01 keiya01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @keiya01 @wusyong