Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All custom protocol handlers are called on Windows #323

Closed
lucasfernog opened this issue Jul 1, 2021 · 6 comments · Fixed by #322
Closed

All custom protocol handlers are called on Windows #323

lucasfernog opened this issue Jul 1, 2021 · 6 comments · Fixed by #322
Assignees

Comments

@lucasfernog
Copy link
Member

I believe the add_web_resource_requested should only be called once and the protocol name needs to be parsed from the URL, calling the proper protocol handler. Currently all handlers are called.

@lucasfernog lucasfernog self-assigned this Jul 1, 2021
@lucasfernog
Copy link
Member Author

I have a fix for this and I believe this will fix tauri-apps/tauri#2124

@timonwimmer-git
Copy link

Maybe I did something wrong - however after trying out your fix, I am still getting that annoying ERR_NAME_NOT_RESOLVED error every third time I open my application.

@wusyong
Copy link
Member

wusyong commented Jul 5, 2021

@timonwimmer-git Did you try wry with commit after 923d346? Or it's just on tauri?
Tauri hasn't updated to latest update of wry I believe.

If it's on wry, I would really appreciate to see a minimum reproducible example. So I'll could track it more clearly.

@timonwimmer-git
Copy link

With commit 923d346!
The thing is, I really can't track it down. If I create a new VM and freshly set-up tauri, it still sometimes happens on the first run! I'll keep digging and get back to you.

@wusyong
Copy link
Member

wusyong commented Jul 5, 2021

Thanks! Hmm, I'll also test with some examples to see if I can find out at the same time.

@timonwimmer-git
Copy link

With commit 923d346, just wry without tauri and using the custom_protocol.rs example (https://github.com/tauri-apps/wry/blob/renovate/windows-0.x/examples/custom_protocol.rs) I consistently got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants