Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add error when failed to register url scheme on macOS, close #1295 #1301

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

pewsheen
Copy link
Contributor

Fixed #1295

I'm not sure what the guidelines are for adding Error; this one might be too specific?

@pewsheen pewsheen requested a review from a team as a code owner June 24, 2024 03:24
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Package Changes Through b6a4177

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.41.0 0.41.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a change file

@amrbashir amrbashir merged commit 556a359 into dev Jun 24, 2024
13 checks passed
@amrbashir amrbashir deleted the chore/add-error-register-url-scheme branch June 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for invalid custom scheme name on webkit
2 participants