-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] When files are found in the installation directory, the installation should be terminated. #9277
Labels
Comments
If this is just about the uninstallation we can fix this as i described here instead. In general i think allowing users to install the app into a not-empty folder is fine but maybe a dialog asking whether they're sure would be nice? 🤔 @amrbashir |
An Ok/Cancel dialog should be fine here |
@keiko233 if you want, please go ahead and open a PR to add a dialog to add an Ok/Cancel dialog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
In the current NSIS setup, installation is allowed in any user-selected directory. During uninstallation, all files in the current path are removed. If there are additional files present in the selected path, non-program files will also be deleted incidentally.
Describe the solution you'd like
We can address this issue during installation by checking if the user-selected path contains existing files, thus preventing potential issues during uninstallation.
Alternatives considered
Perhaps there are alternative and more effective implementations, such as recording the program's files in the registry or exploring other solutions.
Additional context
I have written a sample code here. If allowed, I would like to initiate a pull request.
here keiko233@460519e
associated Links:
libnyanpasu/clash-nyanpasu@78b18de
libnyanpasu/clash-nyanpasu#657
The text was updated successfully, but these errors were encountered: