Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Escape key undetectable in frontend #5790

Closed
probablykasper opened this issue Dec 8, 2022 · 7 comments · Fixed by tauri-apps/wry#798
Closed

[bug] Escape key undetectable in frontend #5790

probablykasper opened this issue Dec 8, 2022 · 7 comments · Fixed by tauri-apps/wry#798
Assignees
Labels
platform: macOS status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@probablykasper
Copy link
Member

probablykasper commented Dec 8, 2022

Describe the bug

As of Tauri v1.2.1, keydown events are no longer emitted for the Escape key on macOS.

In v1.2.0, menubar shortcuts didn't work. v1.2.1 fixed that issue, which might be related (though can't see any changelog entry for it?).

Reproduction

https://github.com/probablykasper/tauri-escape-bug

Expected behavior

No response

Platform and versions

Environment
  › OS: Mac OS 10.15.7 X64
  › Node.js: 18.12.1
  › npm: 8.19.2
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.25.1
  › rustc: 1.65.0
  › cargo: 1.65.0
  › Rust toolchain: stable-x86_64-apple-darwin 

Packages
  › @tauri-apps/cli [NPM]: 1.2.2
  › @tauri-apps/api [NPM]: 1.2.0
  › tauri [RUST]: 1.2.1,
  › tauri-build [RUST]: 1.2.1,
  › tao [RUST]: 0.15.2,
  › wry [RUST]: 0.23.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../build
  › devPath: http://localhost:5179/
  › framework: Svelte
  › bundler: Vite

App directory structure
  ├─ node_modules
  ├─ src-tauri
  ├─ build
  ├─ .git
  └─ src

Stack trace

No response

Additional context

No response

@probablykasper probablykasper added type: bug status: needs triage This issue needs to triage, applied to new issues labels Dec 8, 2022
@FabianLars
Copy link
Member

can you run cargo update to update your tao version? Hopefully this was fixed already 😅

@probablykasper
Copy link
Member Author

It's still there on the latest tao version

@probablykasper
Copy link
Member Author

Pinning tao to =0.15.0 doesn't seem to revert to the old behavior. Maybe it's wry v0.23

@probablykasper
Copy link
Member Author

Narrowed it down, these updates are causing the issue to appear:

tauri-runtime-wry v0.12.1 -> v0.12.2
wry v0.22.6 -> v0.23.1

@wusyong
Copy link
Member

wusyong commented Dec 9, 2022

I can bring it back but the beep error sound will remain.

@probablykasper
Copy link
Member Author

I'd say that's worth, since losing Escape support probably has a pretty big impact, and the beep can be worked around. Hopefully some magical solution is found in the future

@probablykasper probablykasper changed the title [bug] Escape key presses detectable frontend [bug] Escape key undetectable in frontend Dec 9, 2022
@wusyong
Copy link
Member

wusyong commented Dec 9, 2022

I also start another issue to discuss how do we disable the sound afterwards.
tauri-apps/wry#799
Will appreciate any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants