Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check undefined handlebar vars in strict mode #185

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: check undefined handlebar vars in strict mode #185

merged 2 commits into from
Aug 15, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Aug 13, 2023 •
edited
Loading

closes #184

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir changed the title fix: fix undefined handlebar vars in strict mode fix: check undefined handlebar vars in strict mode Aug 13, 2023
lucasfernog
lucasfernog previously approved these changes Aug 15, 2023
View reviewed changes
@lucasfernog lucasfernog merged commit 9719aae into dev Aug 15, 2023
@lucasfernog lucasfernog deleted the fix/handlebars/strict-mode branch August 15, 2023 13:32
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable "android-app-dependencies-platform" not found in strict mode
2 participants
@amrbashir @lucasfernog