Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only bundles are upload #314

Closed
liudonghua123 opened this issue Oct 12, 2022 · 2 comments
Closed

only bundles are upload #314

liudonghua123 opened this issue Oct 12, 2022 · 2 comments

Comments

@liudonghua123
Copy link
Contributor

I see this action only upload the bundles(installer), the executable is not configurable to upload.

For example, it only upload bundles/*.msi for the windows build, I also want to upload join(artifactsPath, `${fileAppName}.exe`).

const artifacts: string[] = []
langs.forEach((lang) => {
artifacts.push(
join(
artifactsPath,
`bundle/msi/${fileAppName}_${app.version}_${process.arch}_${lang}.msi`
)
)
artifacts.push(
join(
artifactsPath,
`bundle/msi/${fileAppName}_${app.version}_${process.arch}_${lang}.msi.zip`
)
)
artifacts.push(
join(
artifactsPath,
`bundle/msi/${fileAppName}_${app.version}_${process.arch}_${lang}.msi.zip.sig`
)
)
})
return artifacts

@FabianLars
Copy link
Member

Duplicate of #302

Keep in mind that this is intended because the .exe is usually not something you can ship to your users.

@FabianLars FabianLars closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
@liudonghua123
Copy link
Contributor Author

Duplicate of #302

Keep in mind that this is intended because the .exe is usually not something you can ship to your users.

However, .exe executable is a green portable app, and the msi installer just wrap the same .exe file for windows platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants