fix: use 'zipfile' module to extract fetches on Windows #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zipfiles generated natively on Windows use backslash path separators for their internal path structure. The `unzip` utility in Linux is unable to interpret this and creates files with `\` in their name rather than directories. Even if a task is running on Windows, the `unzip` utility is bundled with `mozilla-build` and runs in the shell there. So it is still unable to extract the archive properly. This patch switches to extracting with the `zipfile` stdlib rather than the `unzip` utility when running from Windows. Note that the bug can still exist if a task running on Linux attempts to consume a zipfile created from a task on Windows.
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 55.47% 55.47%
=======================================
Files 59 59
Lines 4575 4575
=======================================
Hits 2538 2538
Misses 2037 2037 Continue to review full report at Codecov.
|
|
Going to go with a different approach here. |
|
I found: So this issue was actually fixed in PowerShell, but I guess the VPN workers have a very old version of it installed. For this reason, I don't think it's worth solving in Taskgraph. Instead I'll see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zipfiles generated natively on Windows use backslash path separators for
their internal path structure. The
unziputility in Linux is unable tointerpret this and creates files with
\in their name rather thandirectories.
Even if a task is running on Windows, the
unziputility is bundledwith
mozilla-buildand runs in the shell there. So it is still unableto extract the archive properly.
This patch switches to extracting with the
zipfilestdlib rather thanthe
unziputility when running from Windows.Note that the bug can still exist if a task running on Linux attempts to
consume a zipfile created from a task on Windows.