Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unterminated events in Fuchsia format #20

Open
Sudha247 opened this issue Jul 28, 2023 · 1 comment
Open

Unterminated events in Fuchsia format #20

Sudha247 opened this issue Jul 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Sudha247
Copy link
Member

Sudha247 commented Jul 28, 2023

@kayceesrk reported unterminated events on the current main branch and #17 on the default (fuchsia) format.

image

This is not the case with json format.

image

@Sudha247 Sudha247 added the bug Something isn't working label Jul 28, 2023
@Sudha247
Copy link
Member Author

Sudha247 commented Aug 2, 2023

I spent some time today trying to find the source of this bug. I tried to reproduce this with possible combinations of compiler versions (5.0.0, 5.1.0~beta1), olly version (0.3, trunk) and tracing format (fuchsia, json) on the same program (Eio version of ocurrent's solver service). I could reproduce this with 5.1.0~beta1 + fuchsia, and not json, with both versions of olly. Interestingly, this doesn't occur on 5.0.0!

To make sure the compiler is not skipping emitting some events, I added some GC logs at the start and end of major cycles. From the logs, it's clear that there are no unterminated events.

I suspect something's clobbering writes at the end of event. Will try to dig into this further when I find some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant