Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The repository "archive-mirrors" is not respected in a pull, thus downloads are always from the Internet. #336

Closed
hannesm opened this issue Oct 12, 2022 · 2 comments · Fixed by #337
Closed

The repository "archive-mirrors" is not respected in a pull, thus downloads are always from the Internet. #336

hannesm opened this issue Oct 12, 2022 · 2 comments · Fixed by #337

Comments

@hannesm
Copy link
Contributor

hannesm commented Oct 12, 2022

When executing opam-monorepo pull (after a lock), it looks up the tarball(s) in the local opam cache, but does not reach out to the archive-mirrors specified in the repo file of the repository(ies).

This leads, especially in low bandwidth scenarios with a network-local cache, to a lot of downloads that could be avoided.

As far as I can tell, at the moment, OpamRepository.pull_tree is used -- which does not respect the repository mirrors, but instead e.g. OpamUpdate.download_package_source could be used.
@kit-ty-kate
Copy link
Contributor

See answer in ocaml/opam#5313 for details on how to fix opam-monorepo

@hannesm hannesm mentioned this issue Oct 14, 2022
Merged
@hannesm
Copy link
Contributor Author

hannesm commented Oct 14, 2022

Thanks @kit-ty-kate, I opened a PR here #337 which fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use cache urls from opam config hannesm/opam-monorepo
2 participants
@hannesm @kit-ty-kate