From 421252f4c82fe9d652daa0c4dce4fbbd81697c2c Mon Sep 17 00:00:00 2001 From: Mike the Tike Date: Fri, 12 Nov 2021 13:35:58 +0200 Subject: [PATCH] test: reduce cucumber ci to critical only --- .circleci/config.yml | 2 +- Cargo.lock | 2 +- applications/tari_base_node/src/main.rs | 1 + applications/tari_console_wallet/src/main.rs | 1 + .../src/base_node/state_machine_service/states/listening.rs | 2 +- .../recovery/standard_outputs_recoverer.rs | 2 +- 6 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index e274bcd9b3..f502eb02da 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -129,7 +129,7 @@ commands: - run: name: Run cucumber scenarios no_output_timeout: 20m - command: cd integration_tests && mkdir -p cucumber_output && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken and not @wallet-ffi" --format json:cucumber_output/tests.cucumber --exit --retry 3 --retry-tag-filter "@flaky and not @broken" + command: cd integration_tests && mkdir -p cucumber_output && node_modules/.bin/cucumber-js --profile "ci" --tags "@critical and not @long-running and not @broken and not @wallet-ffi" --format json:cucumber_output/tests.cucumber --exit --retry 3 --retry-tag-filter "@flaky and not @broken" - run: name: Generate report command: cd integration_tests && node ./generate_report.js diff --git a/Cargo.lock b/Cargo.lock index dcb87c9737..0854d87d7c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1125,7 +1125,7 @@ dependencies = [ name = "deps_only" version = "0.1.0" dependencies = [ - "log 0.4.14", + "log", ] [[package]] diff --git a/applications/tari_base_node/src/main.rs b/applications/tari_base_node/src/main.rs index c658bf74e5..d2ab2a1de5 100644 --- a/applications/tari_base_node/src/main.rs +++ b/applications/tari_base_node/src/main.rs @@ -26,6 +26,7 @@ #![deny(unused_must_use)] #![deny(unreachable_patterns)] #![deny(unknown_lints)] +#![deny(clippy::needless_borrow)] /// ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⣶⣿⣿⣿⣿⣶⣦⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀ /// ⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣤⣾⣿⡿⠋⠀⠀⠀⠀⠉⠛⠿⣿⣿⣶⣤⣀⠀⠀⠀⠀⠀⠀⢰⣿⣾⣾⣾⣾⣾⣾⣾⣾⣾⣿⠀⠀⠀⣾⣾⣾⡀⠀⠀⠀⠀⢰⣾⣾⣾⣾⣿⣶⣶⡀⠀⠀⠀⢸⣾⣿⠀⠀⠀⠀⠀⠀⠀⠀⠀ diff --git a/applications/tari_console_wallet/src/main.rs b/applications/tari_console_wallet/src/main.rs index c463d83c0d..86b6eb41a9 100644 --- a/applications/tari_console_wallet/src/main.rs +++ b/applications/tari_console_wallet/src/main.rs @@ -5,6 +5,7 @@ #![deny(unused_must_use)] #![deny(unreachable_patterns)] #![deny(unknown_lints)] +#![deny(clippy::redundant_clone)] #![recursion_limit = "1024"] use crate::{recovery::get_seed_from_seed_words, wallet_modes::WalletModeConfig}; use init::{ diff --git a/base_layer/core/src/base_node/state_machine_service/states/listening.rs b/base_layer/core/src/base_node/state_machine_service/states/listening.rs index 7afea9bd4a..6cd5eb12c3 100644 --- a/base_layer/core/src/base_node/state_machine_service/states/listening.rs +++ b/base_layer/core/src/base_node/state_machine_service/states/listening.rs @@ -205,7 +205,7 @@ impl Listening { // If we have configured sync peers, they are already filtered at this point let sync_peers = if configured_sync_peers.is_empty() { - select_sync_peers(&best_metadata, &peer_metadata_list) + select_sync_peers(best_metadata, &peer_metadata_list) } else { peer_metadata_list }; diff --git a/base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs b/base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs index 33838c0d22..650a6f2bef 100644 --- a/base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs +++ b/base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs @@ -101,7 +101,7 @@ where TBackend: OutputManagerBackend + 'static let script_key = PrivateKey::random(&mut OsRng); UnblindedOutput::new( output.committed_value, - output.blinding_factor.clone(), + output.blinding_factor, features, script, inputs!(PublicKey::from_secret_key(&script_key)),