-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurable exclude dialer addresses for universe #6543
feat: add configurable exclude dialer addresses for universe #6543
Conversation
Test Results (CI) 3 files 129 suites 35m 2s ⏱️ Results for commit 21717d7. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 11 suites 39m 34s ⏱️ For more details on these failures, see this check. Results for commit 21717d7. ♻️ This comment has been updated with latest results. |
d700560
to
583d331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far, I have two issues with the implementation:
1: We should not exclude 172.2.3.4 this is a valid address, we should use 0.0.0.0 which is the special case address and exclude that.
2: We should not ban the node as it will cause issues for that node. We should just exclude it from being dialed. But we should allow that node to dial us.
Addded user configurable communication node addresses that should never be dialled.
8772813
to
3f38620
Compare
Currently, setting To allow a peer to advertize a public address of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make an distinction between peers and address here.
A peer might have an invalid, excluded address. But if the peer has other valid addresses, it should not be excluded and still be include. We should just ignore the invalid address.
Description
Added user-configurable communication node addresses that should never be dialled. In Tari Universe the base node and wallet is configured in a listen-only TCP mode with a fake public address and when their addresses are propagated throughout the network, other peers should not try to dial them.
Motivation and Context
The previous implementation was hard-coded and did not work properly.
How Has This Been Tested?
Added unit tests.
System-level testing.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes