feat: add one-sided addresses to grpc #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 40m 24s ⏱️ Results for commit cf173a3. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)36 tests 36 ✅ 14m 30s ⏱️ Results for commit cf173a3. ♻️ This comment has been updated with latest results. |
stringhandler
previously approved these changes
Sep 9, 2024
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
force-pushed
the
sw_add_both_addresses_to_grpc
branch
from
41d1da3 to
cf173a3
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently get_address grpc call only returns the interactive address. This adds the one-sided address as well, showing both.