Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add console wallet detail #6531

Conversation

hansieodendaal
Copy link
Contributor

Description

Added console wallet detail:

  • Receive tab: Node ID => Node ID / Public key
  • Network tab: Type, Public key => Type, Node ID, Public key

Motivation and Context

To provide more useable information.

How Has This Been Tested?

System-level testing.

What process can a PR reviewer use to test or verify this change?

Code review, system-level testing.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Added console wallet detail:
- Receive tab: `Node ID` => `Node ID / Public key`
- Network tab: `Type, Public key` => `Type, Node ID, Public key`
Copy link

github-actions bot commented Sep 5, 2024

Test Results (CI)

    3 files    129 suites   37m 29s ⏱️
1 308 tests 1 308 ✅ 0 💤 0 ❌
3 910 runs  3 910 ✅ 0 💤 0 ❌

Results for commit ea48b2b.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Test Results (Integration tests)

36 tests   36 ✅  15m 37s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit ea48b2b.

@SWvheerden SWvheerden merged commit 594e984 into tari-project:development Sep 6, 2024
17 checks passed
@hansieodendaal hansieodendaal deleted the ho_add_console_wallet_detail branch September 6, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants